gmusicbrowser Forum

Main board => Suggestions => Topic started by: ochosi on January 24, 2011, 15:49:01

Title: putting additional icon themes in a separate package
Post by: ochosi on January 24, 2011, 15:49:01
the subject of this thread already says it: i'd like to suggest something like a gmusicbrowser-icons package (or even a simple tarball could be ok as a start). this would make it easier to make more community icon themes available while keeping the gmusicbrowser package itself slim.

the second thing i wanted to mention is doing a page similar to the themes page of claws-mail (http://www.claws-mail.org/themes.php?section=downloads) to get a quick overview of the themes (meaning: standardized screenshots/previews).

i'd like to have some feedback on both ideas, if you think this is a good idea we could start to implement it in the wiki (or even in the static html-version if quentin approves).
Title: Re: putting additional icon themes in a separate package
Post by: Photon on September 08, 2011, 18:41:27
Is there anything new on this? I'd like to make an Arch Linux PKGBUILD for additional GMB icon themes but currently only the Faenza theme is not included into the main GMB package. I'd suggest either including it into the main tree or separating all the themes into an individual package, the current state is somewhat unsystematic. :)
Title: Re: putting additional icon themes in a separate package
Post by: Quentin Sculo on September 10, 2011, 02:19:30
I might add the Faenza theme, or else you could include it in an "extra" package that also contains extra layouts, I will add a number of layouts, but not those that require background pictures and things like that, those would fit better in an "extra" package.
Title: Re:putting additional icon themes in a separate package
Post by: Photon on September 10, 2011, 15:46:41
I think, adding Faenza to the main package is the better solution, a package with just one additional icon theme and some additional layouts is somewhat mixed up. If too many new icon themes appear to include all of them into the main package, one can still move all of them to an extra icon theme package.
Title: Re: putting additional icon themes in a separate package
Post by: Photon on March 13, 2013, 17:02:35
Hello guys,

has any progress been made on this? I had some free time and have created a Faenza Dark theme based on the Faenza theme  from shimmerproject https://github.com/shimmerproject/gmusicbrowser/tree/master/pix/Faenza and also edited the Faenza theme a bit by adding the rating star icons and other small changes. You can have a look here: https://dl.dropbox.com/u/1507406/gmb_faenza_dark.png and find the theme here: https://dl.dropbox.com/u/1507406/gmb_faenza.tar.gz I'd be glad if it can be included into gmusicbrowser or shimmerproject. In the latter case I would create a PKGBUILD for the Faenza theme finally. :) Btw, if anything needs to be changed, please tell me so.

Photon
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on March 26, 2013, 05:18:14
Hey Photon,
sorry for the late reply. Seeing that you put some effort into a variant of the icon-theme and talking to Quentin about the inclusion of Faenza by default made me clean up the icon theme a bit and create a few missing icons.
It should now be complete (in the shimmer github repo), so please pull it and let me know what you think.

I think the two variants should be consistent in the icons they use, so we should harmonize them in some aspects. There also shouldn't be any duplicates, so if you wanna keep the queue icons in from the elementary-icon-theme they'd have to become symlinks. gtk-preferences_20 can be dropped, I used to use that specifically in a layout of mine, but I later realized that customizations like this don't really make that much sense.

I took a quick look into Faenza-darkest today and there a few icons that I'd replace with the versions from upstream, simply because it's more consistent with the rest of the desktop then. (E.g. view-list-compact, view-list-icons, view-list-details)

So the good news is that the icons will get included, but we have to finalize them first!
Cheers,
Simon
Title: Re: putting additional icon themes in a separate package
Post by: Photon on March 27, 2013, 18:02:31
Hi, thanks for the reply. Nice that Faenza finally gets included!

I pulled the updated version and I find the changes quite good. One question: Why are the star icons missing the half-valued numbers?

I'm trying to get the dark version more consistent. Following icons are currently missing in the dark version: gmb-filter, gmb-library and gmb-random. Did you create them on your own or it's just me being unable to find them?

I didn't use symlinks to Faenza in the dark variant, since I wasn't sure about the inclusion of Faenza into the package and wanted to be able to make two independent Arch packages for both variants, in the case that it cannot be included. Now since it will be included, I will use symlinks to Faenza in the dark version if some icons are identical in both variants.

Photon
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on March 27, 2013, 18:06:40
I didn't add the half-valued stars because I was lazy mostly :)
The way the rating system works, it just gets more/less accurate with the number of stars an icon-theme holds. So it's not a real problem, just not ideal maybe.

The three icons you mentioned were created by me, they're not part of the original Faenza icon-theme.

Do you have a github account? If so, I'd say I'll give you access to the shimmer repo of gmusicbrowser, then we can host the icons there for the time being. As soon as they're release-ready, it'll be easy for Quentin to pull them from there.
Title: Re: putting additional icon themes in a separate package
Post by: Photon on March 27, 2013, 18:20:51
Quote
I didn't add the half-valued stars because I was lazy mostly :)

I see.  :D I'm not using the rating stuff at all, so I have no feeling about the half stars being useful, but I can well imagine that one doesn't really use such an accurate rating.

I will then try to patch together dark versions of those three icons.

I have a github account, but I only used it for reporting and commenting some bugs so far, so I'm not in the picture yet concerning using git/github. Here's my account: https://github.com/Photon89 .
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on March 27, 2013, 19:53:40
Hey, you should have push-rights for the repository now. I'd suggest you make yourself familiar with basic git and then push your icons there!
Title: Re: putting additional icon themes in a separate package
Post by: Photon on March 28, 2013, 00:45:33
Sorry for the dumb question, but I have following problem:

Code: [Select]
[[email protected] gmusicbrowser]$ git remote add origin [email protected]:shimmerproject/gmusicbrowser.git
fatal: remote origin already exists.
[[email protected] gmusicbrowser]$ git push origin master
fatal: remote error:
  You can't push to git://github.com/shimmerproject/gmusicbrowser.git
  Use [email protected]:shimmerproject/gmusicbrowser.git

Shall I use some other name rather than "origin" or is there anything else I do wrong?
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on March 28, 2013, 04:17:26
Make it easy on yourself and pull the git repo to a clean folder like this:
"git clone [email protected]:shimmerproject/gmusicbrowser.git"

This is already the ssh access, so you should be able to push into this repo as well then. (git add, git commit and git push are your friends)
Title: Re: putting additional icon themes in a separate package
Post by: Photon on March 28, 2013, 16:26:08
Thanks, seems to have worked now. I will let you know, when the three missing icons are done, but it can take some time, since I'm not that good in Gimp.
Title: Re: putting additional icon themes in a separate package
Post by: Photon on April 19, 2013, 12:36:20
I have realized that my Gimp skills are almost non-existent, so if you feel like completing the dark theme (three icons missing: gmb-filter, gmb-library and gmb-random), please feel free to do so. :)
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on April 21, 2013, 06:11:26
OK, I'll see when I get to drawing up those three.
For now I uploaded a new version to the shimmer-PPA which includes your icon-theme.
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on April 21, 2013, 15:42:58
My bad, forgot to adjust the Makefile. It'll be in the next version/update!
Title: Re: putting additional icon themes in a separate package
Post by: Photon on April 21, 2013, 18:52:59
Thanks! I'm using Arch Linux, so I cannot test the PPA, but I tried building from git and stumbled upon a problem in the makefile, should be fixed now.

edit: I have stumbled upon another problem now: I was using the official gmusicbrowser version and there was a layout "Queue, Library & Context" which is now missing in the shimmer version:

Code: [Select]
Layout 'Queue, Library & Context' not found, using 'Shimmer Desktop' instead
Has it got lost somehow or has it been removed intentionally? :)

edit2: I noticed that some icons are to small: http://dl.dropbox.com/u/1507406/Auswahl_001.png Can they be enlarged or would it be bad in some situations (say, the buttons are to small for the icons)?
Title: Re: putting additional icon themes in a separate package
Post by: ochosi on May 03, 2013, 11:59:39
Hey,
the layout was renamed at some point to "Lists, Library & Context" in gmusicbrowser, so you're probably using an older version of it.

About the icons: yeah, those can probably be resized to be crisp - in general the problem is that we can only supply one icon-size in gmusicbrowser-icon-themes and gtk-themes can define the size of icons on buttons. So in the end they can always end up being fuzzy.

I'm rather busy at work at the moment, so I won't be able to take care of those icons, but if you want to, feel free to go ahead!