Author Topic: Support for discogs.com in the Picture finder plugin  (Read 4538 times)

trasdahl

  • Jr. Member
  • **
  • Posts: 28
    • View Profile
Support for discogs.com in the Picture finder plugin
« on: June 28, 2011, 16:39:44 »
Discogs.com just updated their API, and they no longer require an API key. I tried to add support for discogs.com earlier, but somehow the site didn't accept the request from gmb. However, with this commit from Quentin, it does. To celebrate this, I added support for discogs.com in the Picture Finder plugin. The file is attached.

ochosi

  • Full Member
  • ***
  • Posts: 187
    • View Profile
Re: Support for discogs.com in the Picture finder plugin
« Reply #1 on: June 28, 2011, 22:38:53 »
hey,
looks great! i'll wait for quentin to pick it up and if not it'll appear in the shimmer-fork if you're ok with it ;)

Quentin Sculo

  • Administrator
  • Hero Member
  • *****
  • Posts: 1082
    • View Profile
Re: Support for discogs.com in the Picture finder plugin
« Reply #2 on: June 29, 2011, 01:14:36 »
Thanks, I'll commit it, just tell me which name and email I should put it the commit

VastOne

  • Full Member
  • ***
  • Posts: 200
    • View Profile
Re: Support for discogs.com in the Picture finder plugin
« Reply #3 on: June 29, 2011, 10:16:57 »
This is a fantastic addition to the search for quality album art..

Discog always seems to have just what I am looking for or need

I really appreciate this - Thank you!

 8)

trasdahl

  • Jr. Member
  • **
  • Posts: 28
    • View Profile
Re: Support for discogs.com in the Picture finder plugin
« Reply #4 on: June 29, 2011, 15:30:56 »
Commit it if you think it's good enough (I'm not an expert in perl regexes). Name is Øystein Tråsdahl and mail is trasdahl(at)gmail.com. (I don't care if my name is in the commit, though.)

Perhaps you noticed that the "More results" feature doesn't work with the discogs parser. That is because the search url is not in the results page. It could be easily fixed if the url was passed along from the calling functions (or saved in $self->{url}), but I didn't want to meddle with the rest of the code.