Author Topic: Apparent bug in 'count song as played'  (Read 2354 times)

bucaneer

  • Jr. Member
  • **
  • Posts: 33
    • View Profile
Apparent bug in 'count song as played'
« on: October 06, 2010, 15:55:04 »
There's some sort of bug in the way "Threshold to count song as played" setting is interpreted. For example, setting it to "60% or 300 seconds" makes it that songs longer than 300 seconds never get registered as played. I imagine the expected behaviour is to check whichever condition is reached first, so that a 3:20 song is counted as played at 2 minute mark (60%), while a 15:00 one would be counted at 5 minutes (300 seconds). I don't have time to look at the code, so I'm reporting it here.

Quentin Sculo

  • Administrator
  • Hero Member
  • *****
  • Posts: 1082
    • View Profile
Re: Apparent bug in 'count song as played'
« Reply #1 on: October 06, 2010, 17:31:23 »
Thanks for reporting this bug.
fixed in http://git.gmusicbrowser.org/commit/a0959187a6
I got confused in the code about whether I was returning true for a full play or returning true for a partial play.