gmusicbrowser Forum

Main board => Questions => Topic started by: bluealbum on January 17, 2011, 07:11:34

Title: Missing items in the language translation.
Post by: bluealbum on January 17, 2011, 07:11:34
 ;D ;D ;D ;D
I found bugs....
eng -> kor translate.
some entries for the korean language don't exist.

1.
########################################################################
--- 0/gmusicbrowser_list.pm   2011-01-14 04:41:12.000000000 +0900
+++ gmusicbrowser-adcc424/gmusicbrowser_list.pm   2011-01-17 09:17:41.758735009 +0900
@@ -721,20 +721,20 @@
    },
 
    right_aligned_folder=>
-   {   menu   => _"Folder (right-aligned)", title => _"Folder",
+   {   menu   => _("Folder (right-aligned)"), title => _("Folder"),
       value   => sub { Songs::Display($_[2],'path'); },
       attrib   => 'text', type => 'Glib::String', depend => 'path',
       sort   => 'path',   width => 200,
       init   => { ellipsize=>'start', },
    },
    titleaa =>
-   {   menu => _('Title - Artist - Album'), title => _('Song'),
+   {   menu => _("Title - Artist - Album"), title => _("Song"),
       value => sub { ::ReplaceFieldsAndEsc($_[2],"<b>%t</b>\n<small><i>%a</i> - %l</small>"); },
       attrib => 'markup', type => 'Glib::String', depend => 'title artist album',
       sort => 'title:i',   noncomp => 'boldrow',      width => 200,
    },
    playandqueue =>
-   {   menu => _('Playing & Queue'),      title => '',   width => 20,
+   {   menu => _("Playing & Queue"),      title => '',   width => 20,
       value => sub { ::Get_PPSQ_Icon($_[2], ($_[0]{currentrow}!=-1 && $_[0]{currentrow}!=$_[1])); },
       class => 'Gtk2::CellRendererPixbuf',   attrib => 'stock-id',
       type => 'Glib::String',         noncomp => 'boldrow italicrow',
########################################################################

2. gmusicbrowser_songs.pm  : translate item not found. in pot. -> ("Unknown filter : '$f')

line 3684   :   else { $text.="Unknown filter : '$f'(FIXME)\n"; }

3. menu -> Playlist filter -> Custom...
   filter editon -> "filters" <-----  translate item not found. in pot.

4. here is korean language ko.po file.

Thank always.  ;D ;D ;D
Title: Re: Missing items in the language translation.
Post by: Quentin Sculo on January 17, 2011, 23:06:52
1. the first one was indeed not translated, but the 2 others are ok. But these are for the SongList, I've noticed that the SongTree doesn't use translations for the columns defined in the layouts file, I'll fix it.

2. I'm working on this part, so I'll fix it at the same time

3. yes it was missing, I fixed it along with the one in 1. : http://git.gmusicbrowser.org/commit/46508c049e

4. thanks a lot for the translation, just to be sure, do you mind if I commit it as bluealbum and using the email you've put in the ko.po file ?
Title: Re: Missing items in the language translation.
Post by: bluealbum on January 18, 2011, 05:58:58
Sure! No problem.  ;D ;D ;D
Title: Re: Missing items in the language translation.
Post by: Quentin Sculo on January 18, 2011, 22:48:29
I've pushed your translation :)
And SongTree column and group names are now translatable : http://git.gmusicbrowser.org/commit/da0b7c650f