Show posts

This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.

Messages - trasdahl

16
Suggestions / Key bindings
August 30, 2011, 09:44:24
It kinda bugs me that some layout items steal some keyboard shortcuts, making them useless as global key bindings. For example, SongLists and SongTrees steal both space and ctrl-space, so they are useless as play/pause shortcuts. SongLists even steal ctrl-p, which I use for opening the Settings window.

My suggestion is that all key bindings are grabbed by gmb and checked against the keybindings list before the layout item in focus gets the chance to react to it. If the key or key combination is in the global keybindings list, it should not be passed on to the current layout item in focus. There should be one exception to this: key bindings that are plain letters or space (without ctrl or alt) should not be grabbed when a text field has focus (for example SimpleSearch or inline search in a SongList or SongTree). Typically, you want to be able to type a search string that includes a space, even if you have space as a play/pause shortcut key. This is the way itunes and spotify work and I find it intuitive.
17
Customization / Re: [PLUGIN] Albuminfo
July 11, 2011, 15:18:55
Btw, I noticed an interesting bug myself. If you choose "Auto-save fields" and "Add to existing values", each song in the album is saved separately. I think it has to be done that way. So, if the album contains a lot of songs and if your computer is a bit slow, then the progress window pops up with one progress bar for each song, stacked vertically. If there are a LOT of songs, the progress window becomes extremely "tall", actually so tall that compiz crashes with the report "Max texture size exceeded" (or something like that).

Now how about that, huh? :)

I'm not quite sure what to do about it.
18
Customization / Re: [PLUGIN] Albuminfo
July 11, 2011, 15:04:26
Thanks for the feedback.

I don't have much time to fix bugs and features these days, and with the summer holiday coming and all, it might be some time (days, weeks). Sorry about that.

If anybody wants to contribute, though, feel free! :)
19
Customization / Re: [PLUGIN] Albuminfo
July 04, 2011, 12:08:44
Hello again.

Quotemaybe the generic album and artist icons would be better for that. what do you think?

I don't really have an opinion about the icons. But it kinda depends on the scope of the plugin. I was uncertain whether I should call it allmusic-plugin or albuminfo plugin. If people think there should be one albuminfo-plugin for allmusic, last.fm etc., then I guess generic icons are sensible.

Quoteif no review is found, there's a button to show lastfm info instead.

I was considering togglebuttons such as the "biography, events & similar"-buttons in artistinfo. Or it could be done the way you describe. But once you add more than one source, then maybe stuff such as "manual search" and "auto-save fields" becomes confusing. Maybe I can try it out, see how it works.

Quoteif the widget isn't loaded/shown in the layout, there's an entry in the album-context-menu to open that pane/plugin in a new window.

You have the "Open Context window" command in the standard main menu, don't you think that's enough?

QuoteI would appreciate 'scan the whole library'

I can try, though I'm not quite sure how to :). I think it would be pretty slow, and I don't know if it would be safe if you for example cancel the process by shutting down gmb.
20
Customization / [PLUGIN] Albuminfo
June 30, 2011, 12:15:06
I've written a plugin based on (and similar to) the artistinfo plugin, except it retrieves information about albums, and it does so from allmusic.com. The plugin displays the album review in a Context widget, and offers to save some of the information (genre, moods, styles and themes) in gmb fields. This requires some fields to be enabled/created, so I cite my README:

GENRES IS THE ONLY FIELD EXISTING AND ENABLED IN GMUSICBROWSER BY DEFAULT. "Moods" exists, but must be enabled. This can be done under Preferences -> Fields -> Standard fields -> mood. "Styles" and "Themes" must be created by the user under Preferences -> Fields -> Custom fields. Click "New custom field", call it "Style" (yes, capitalized). Field type must be "flags". Field name is what appears in the filter pane tab, and can be chosen freely ("Styles" is natural). Do the same for "Themes". Moods, Styles and Themes will now be available as filter panes, songtree columns etc.

For more information, read the README.

If (or should I say when) you find any bugs, please tell me! Also let me know if you have any feature requests.
There's a TODO list in the source file, but it's actually more of a "Suggestions" list, so I don't know if I'll implement them unless someone tells me to :)

I hope you find it useful and that it doesn't break anything :)
21
Commit it if you think it's good enough (I'm not an expert in perl regexes). Name is Øystein Tråsdahl and mail is trasdahl(at)gmail.com. (I don't care if my name is in the commit, though.)

Perhaps you noticed that the "More results" feature doesn't work with the discogs parser. That is because the search url is not in the results page. It could be easily fixed if the url was passed along from the calling functions (or saved in $self->{url}), but I didn't want to meddle with the rest of the code.
22
Discogs.com just updated their API, and they no longer require an API key. I tried to add support for discogs.com earlier, but somehow the site didn't accept the request from gmb. However, with this commit from Quentin, it does. To celebrate this, I added support for discogs.com in the Picture Finder plugin. The file is attached.
23
Questions / Re: Queue: normal operation mode?
May 12, 2011, 10:47:49
I agree with berarma about the intuitive behavior of the queue.
24
It seems there is a bug in the picture finder plugin. When I open an "Artists" (note: not "Artist") tab in a filter pane, right click and choose "search for a picture on internet", the following occurs:

- the name of the artist in the search field is always "1"
- i correct the artist name, and choose a picture from the new search results
- in the "save as" dialog, the check box at the bottom says "Use this picture for artist 'ARRAY(0xd8a9f7)'"
- When I click OK, the memory usage of GMB boosts up to 1.1GB! (And the picture is set correctly.)

I guess the easy solution to this problem is to disable the option to search for a picture in the "Artists"-pane...
25
Suggestions / Re: comprehensive lastfm plugin
April 06, 2011, 07:08:57
Yup, I noticed, and i works exactly the way it should :) I was merely suggesting it because it would be nice to combine the one-time import and pulling playcount with the rest of the functionality in one grand unified last.fm plugin. But as long as the functionality is available, I guess it's not the biggest priority.
26
Suggestions / Re: comprehensive lastfm plugin
April 05, 2011, 08:00:05
Quotefilterpane with locally available similar artists
i was thinking about a filterpane tab along with artist, album genre etc., but i guess it would be confusing to mix the last.fm info in with the normal filters. Besides, maybe this is impossible in a plugin?

Quoteiirc there are a few problems with distinguishing multiple versions of a track
the track.getInfo function in the last.fm api accepts either artist+track (which can result in ambiguities) or a musicbrainz id (which is unique). The resulting xml document contains a mbid tag which i guess could be checked up against musicbrainz? To me the ambiguity isn't too big a problem, but i agree it's not very pretty.

Quoteatm there's a script to do that one-time sync
i know, but it took forever and gave me only a 500 server error. And besides, it's an external script, which i guess would exclude some users. It seems that the script pulls weekly chartlists. I think it is possible to use user.getTopTracks and add the limit=1000 option, which would result in fewer requests.

Quotepulling the playcount info from lastfm when playing back sounds wrong after you've once synced your playcounts
i scrobble from all sorts of different sources, which means the last.fm playcount increases faster than the gmb playcount.

Quotelast.fm radio ...
there are some free tracks, so it is possible to build a radio station without subscribing (the rhythmbox last.fm plugin does this). but it may be so limited that it's not worth it.

anyway, great initiative!
27
Suggestions / Re: comprehensive lastfm plugin
April 04, 2011, 13:17:39
Here is my wish-list:

- expanding the Context widget to also include top tracks and top albums by the current artist.
- popularity (either as total listeners or total playcount) available as a songlist/sontree column, perhaps displayed as rating stars, a progress bar or something like the column that Spotify uses.
- filterpane with locally available similar artists.
- option "Find songs by similar artists" in the right-click popup menu in songlists.
- option to sync playcount with last.fm, meaning: first a one-time import (possibly available later as a button in preferences), then updating the playcount whenever a track starts playing.
- last.fm radio stations (streaming).
- option to fill/autocorrect (selected) tags in the song properties dialog.
28
Questions / Set filter from custom widget
March 21, 2011, 15:45:40
Is there a command that would allow me to set a filter from any layout item through a click1-action? I would like to be able to write something like

"Artist(click1=SelectArtist(%a))"

or

"Album(click1=SetFilter(artist,%a))"

or maybe something with a generic Button. Is it possible? Maybe through a "RunPerlCode"-command?